This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Make default cpu and memory configurable #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
resouer
reviewed
May 24, 2017
cmd/frakti/frakti.go
Outdated
| @@ -58,6 +58,8 @@ var ( | |||
| enableAlternativeRuntime = pflag.Bool("enable-alternative-runtime", true, "Enable alternative runtime to handle OS containers, default is true") | |||
| cgroupDriver = pflag.String("cgroup-driver", "cgroupfs", "Driver that the frakti uses to manipulate cgroups on the host. *SHOULD BE SAME AS* kubelet cgroup driver configuration. Possible values: 'cgroupfs', 'systemd'") | |||
| rootDir = pflag.String("root-directory", "/var/lib/frakti", "Path to the frakti root directory") | |||
| defaultCPUNum = pflag.Int("cpu", 1, "Default CPU number for HyperVM when cpu is not specified for the pod") | |||
There was a problem hiding this comment.
I think it worth to say cpu limit and memory limit here.
resouer
reviewed
May 24, 2017
cmd/frakti/frakti.go
Outdated
| @@ -58,6 +58,8 @@ var ( | |||
| enableAlternativeRuntime = pflag.Bool("enable-alternative-runtime", true, "Enable alternative runtime to handle OS containers, default is true") | |||
| cgroupDriver = pflag.String("cgroup-driver", "cgroupfs", "Driver that the frakti uses to manipulate cgroups on the host. *SHOULD BE SAME AS* kubelet cgroup driver configuration. Possible values: 'cgroupfs', 'systemd'") | |||
| rootDir = pflag.String("root-directory", "/var/lib/frakti", "Path to the frakti root directory") | |||
| defaultCPUNum = pflag.Int("cpu-limit", 1, "Default CPU limit in number for HyperVM when cpu is not specified for the pod") | |||
There was a problem hiding this comment.
I mean: Default CPU in number for HyperVM when cpu limit is not specified for the pod. Because there's also cpu request in k8s， which frakti do not care.
Signed-off-by: Pengfei Ni <[email protected]>
This was referenced Jun 28, 2017
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the default 64MB memory is not sufficient. This PR makes the default cpu and memory configurable.
It should help with rook.io (#151) with setting default memory to 512MB.